Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple macro errors #612

Merged
merged 6 commits into from
Dec 5, 2024
Merged

fix: multiple macro errors #612

merged 6 commits into from
Dec 5, 2024

Conversation

Computerdores
Copy link
Collaborator

@Computerdores Computerdores commented Nov 29, 2024 •
edited
Loading

Changes:

  • ports the applicable fixes from Sidecar macro fixes #403 48f51a5
  • fixes a bug where AUTOFILL would be run on the wrong entry a12e3cb
  • fixes a case where BUILD_URL would add an empty Source field 191ed29
  • fixes an error that would cause the Tags from AUTOFILL not to be added if at least one of the tags' names collided with an existing tag's name 5c7c34d

@Computerdores Computerdores added Type: Bug Something isn't working as intended Status: Review Needed A review of this is needed labels Nov 29, 2024
@CyanVoxel CyanVoxel added TagStudio: Library Relating to the TagStudio library system Priority: Medium An issue that shouldn't be be saved for last labels Nov 29, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Nov 29, 2024
@Computerdores Computerdores mentioned this pull request Nov 30, 2024
Open
@CyanVoxel CyanVoxel added Status: Mergeable The code is ready to be merged and removed Status: Review Needed A review of this is needed labels Dec 5, 2024
@CyanVoxel CyanVoxel merged commit 3196678 into TagStudioDev:main Dec 5, 2024
5 checks passed
@CyanVoxel CyanVoxel removed the Status: Mergeable The code is ready to be merged label Dec 5, 2024
DandyDev01 pushed a commit to DandyDev01/TagStudio that referenced this pull request Dec 13, 2024
@Computerdores @DandyDev01
fix: multiple macro errors (TagStudioDev#612)
a10d66c 
* port fixes from json branch

* fix: correctly pass grid_idx in autofill macro

* fix(BUILD_URL macro): only add url if url was successfully built

* fix(AUTOFILL macro): error when trying to add tag with name that already exists

* fix: test was wrongly renaming sidecar file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyanVoxel CyanVoxel CyanVoxel approved these changes

Assignees
No one assigned
Labels
Priority: Medium An issue that shouldn't be be saved for last TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
TagStudio Development
Status: ✅ Done
Milestone
SQL Parity
Development

Successfully merging this pull request may close these issues.
2 participants
@Computerdores @CyanVoxel