fix: clear all setting values when opening a library #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computerdores
approved these changes
Dec 2, 2024
|
I didn't seem to encounter the bug on macOS, but I do seem to encounter it on Windows, and this seems to address it! |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/TagStudio
that referenced
this pull request
Dec 4, 2024
DandyDev01
pushed a commit
to DandyDev01/TagStudio
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
self.settings.clear()withself.settings.remove("")in theupdate_libs_list()method. the original implementation was clearing all settings. this bug prevented the app from reopening the last library also. and surprisingly no one noticed or reported it. this change ensures only the intended group of settings is cleared without affecting other values.