fix: [Bug]: Path tests failing on Windows #616 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent always fails in windows.
CyanVoxel
added
Type: Bug
|
LGTM, and this passes on both Windows and macOS. And just so this is public, |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/TagStudio
that referenced
this pull request
Dec 4, 2024
DandyDev01
pushed a commit
to DandyDev01/TagStudio
that referenced
this pull request
Dec 13, 2024
* fix: tagstudio/tests/test_driver.py::test_evaluate_path_last_lib_present always fails in windows. * refactor: removal tagstudio/tests/test_library.py::test_save_windows_path Fixes TagStudioDev#616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagstudio/tests/test_driver.py::test_evaluate_path_last_lib_presenttest, updated the test to explicitly define aQSettingsfile and format to address a bug causing test failures. previously,QSettings()was constructed without specifying an organization or application name. which per the documentation, prevents reading or writing settings. the new implementation creates a temporary settings file and uses it to save the settings. this ensures the test can properly save and read the settings.tagstudio/tests/test_library.py::test_save_windows_pathremoved, which isnt' testing anything meaningfully.resolves #616