Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement search equivalence of "jpg" and "jpeg" filetypes #649

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

Computerdores
Copy link
Collaborator

Implements feature from the roadmap:

Optional consolidation of extension synonyms (i.e. ".jpg" can equal ".jpeg")

More equivalencies can easily be added through modifying a constant in src/core/library/alchemy/visitors.py.

(No issue because this is a short PR and because I don't think anyone else is touching the search rn)

@Computerdores Computerdores added Type: Enhancement New feature or request Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed TagStudio: Search The TagStudio search engine labels Dec 17, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great! And thank you for updating the roadmap, too!
Approved when suggestions are addressed 👍

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Dec 22, 2024
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Dec 22, 2024
Copy link
Member

@CyanVoxel CyanVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for your work on this!

@CyanVoxel CyanVoxel merged commit 9eed3b6 into TagStudioDev:main Dec 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Doesn't require immediate attention TagStudio: Search The TagStudio search engine Type: Enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants