Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Bug] "Fix Unlinked Entries" not functioning, only returns None count #653

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

SkeleyM
Copy link
Contributor

@SkeleyM SkeleyM commented Dec 21, 2024

fixes use of count instead of self.missing_count

close #652

@Computerdores Computerdores added Type: Bug Something isn't working as intended TagStudio: Library Relating to the TagStudio library system Priority: High An important issue requiring attention Status: Review Needed A review of this is needed labels Dec 21, 2024
@Computerdores
Copy link
Collaborator

This does fix the bug outlined in #652, however relinking is still broken even with this fix. Would you be interested in fixing that as well in this PR?

@SkeleyM
Copy link
Contributor Author

SkeleyM commented Dec 21, 2024

@Computerdores
so pressing "Refresh All" is supposed to relink an entry if it is replaced in its original location?
if im not mistaken it's an easy fix.

Refresh all seems to relink the entry just fine just not refreshing the thumbnail. id be happy to fix it.

@Computerdores
Copy link
Collaborator

@Computerdores so pressing "Refresh All" is supposed to relink an entry if it is replaced in its original location? if im not mistaken it's an easy fix.

"Refresh All" is supposed to search for unlinked entries and is working as it is supposed to now afaict. "Search & Relink" is supposed to also relink them, but this is currently broken for me. So if I for example rename a file "Refresh All" now correctly reports 1 unlinked entry, however pressing "Search & Relink" doesn't relink the entry to the renamed file.

Since #652 was only reporting about "Refresh All" being broken, fixing this could be considered out of scope, however it could also make sense do fix that here as well, hence my question of whether you would like to work on that here as well.

Hope that clears up any confusion!

@SkeleyM
Copy link
Contributor Author

SkeleyM commented Dec 21, 2024

thanks for clearing that up, i'm sorry but working on that is something i'd prefer not to do

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Dec 22, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Dec 22, 2024
@CyanVoxel
Copy link
Member

Thank you so much for the fix! Now that this reveals a deeper issue with the relinking functionality, I'll open up a separate issue for that.

@CyanVoxel CyanVoxel merged commit 4c3ff42 into TagStudioDev:main Dec 22, 2024
5 checks passed
@SkeleyM SkeleyM deleted the fix_unlinked_entries branch December 24, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: "Fix Unlinked Entries" not functioning, only returns None count
3 participants