-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy and Paste + Shortcuts #79
Conversation
when I select multiple items, it copies the fields from the first item selected only. Is that intended behaviour? Eg. selected item 1: selected item 2: target item: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice done overall, but there's a few things which could improve the code readability.
Co-authored-by: yed podtrzitko <[email protected]>
I intended to copy the last item from the selection, but forgot the break |
- Multi-selection copy now merges fields of all selected entries - Action states are now handled
I've made some significant changes to this, including:
I'll be labeling this as "review needed" to get some extra eyes on these changes. While there can be some funkiness with the copy paste behavior at times, I believe most of that is due to preexisting bugs with the field system and just the general awkwardness of it compared to the upcoming changes to it. If there are any bugs specifically related to my changes here then I'll be happy to address them. I think the copy/paste actions should also be in the context menu for the ItemThumbs themselves, however I most likely won't be able to implement that until tomorrow. |
* Fixed merge conflicts * fixed format? * Improve readability (Apply suggestions from code review) Co-authored-by: yed podtrzitko <[email protected]> * bug fix: Copy last selected not first * Fix copy entanglement; Fix paste overwriting * Change multi-selection copy to merge data - Multi-selection copy now merges fields of all selected entries - Action states are now handled --------- Co-authored-by: yed podtrzitko <[email protected]> Co-authored-by: Travis Abendshien <[email protected]>
Added buttons to copy and paste the fields of entries and their shortcuts (Ctrl+C, Ctrl+V)
It would be good to add the ability to unselected selected entries by clicking at the background or other elements in order to avoid accidents.