Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open libraries from v9.5.0-pr1 in newer versions #815

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

CyanVoxel
Copy link
Member

Summary

This PR provides a critical fix for opening libraries created in v9.5.0-PR1 as well as providing improved feedback for library opening errors, adding tests for migrating from previous SQLite library versions, and adding documentation for internal database format changes.

Fixes

  • Libraries created in v9.5.0-PR1 (DB_VERSION 6) can now properly be opened with the current version of the program
  • The window title is no longer completely replaced by the name of the error encountered when opening a library

Additions

  • The full error traceback is now provided as part of the error message given when failing to open a library
  • Added test cases for opening all versions of the library database (DB_VERSION 6, 7, and 8)
  • Added documentation for the history of the save file format changes

Fixes #813.


Example of the traceback generated by #813 shown in the new message box (macOS).
Screenshot 2025-02-23 at 12 06 49

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: Documentation Additions/changes to documentation Priority: Critical An issue that requires immediate attention Type: UI/UX User interface and/or user experience TagStudio: Library Relating to the TagStudio library system labels Feb 23, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Feb 23, 2025
@CyanVoxel CyanVoxel merged commit b1126d5 into main Feb 24, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the fix-813 branch February 24, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical An issue that requires immediate attention TagStudio: Library Relating to the TagStudio library system Type: Bug Something isn't working as intended Type: Documentation Additions/changes to documentation Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: PR4 cannot open libraries made in PR1.
1 participant