Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick hack for multiword #17

Merged
merged 4 commits into from
Apr 19, 2020
Merged

Conversation

KoichiYasuoka
Copy link
Contributor

Just hacking for issue #15

@asajatovic
Copy link
Collaborator

@KoichiYasuoka thanks for the contribution. Before merging this in master, I would appreciate it if you could add test(s) for this. More specifically, it would be awesome if the new test(s) could include a language with multi-word tokens.

@KoichiYasuoka
Copy link
Contributor Author

KoichiYasuoka commented Apr 17, 2020

I've just written tests/languages/fr/test_fr_language.py with "Attention aux articles contractés!" and the test suite has passed with the multi-word token "aux" into "à les".

@asajatovic
Copy link
Collaborator

I've just written tests/languages/fr/test_fr_language.py with "Attention aux articles contractés!" and the test suite has passed with the multi-word token "aux" into "à les".

Excellent!

@asajatovic asajatovic merged commit 263c880 into TakeLab:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants