Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests on Windows #39

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Fix failing tests on Windows #39

merged 4 commits into from
Jul 26, 2021

Conversation

mariosasko
Copy link
Contributor

This PR makes necessary changes in the codebase to fix 2 failing tests on Windows (tests/test_spacy_udpipe.py::test_pipe and tests/languages/en/test_en_language.py::test_spacy_udpipe_pretokenized) and improves style.

Changes:

  • adds the __reduce__ dunder to UDPipeModel for nlp.pipe support on Windows
  • uses Word.setSpaceAfter to set the misc field instead of manually setting it (word.misc = "SpaceAfter=No")
  • removes unnecessary "inherit from object" from class declarations

@mariosasko mariosasko requested a review from asajatovic July 23, 2021 16:16
@mariosasko mariosasko mentioned this pull request Jul 24, 2021
@mariosasko
Copy link
Contributor Author

Think we should add windows-latest to the list of runners in the workflows file to avoid such errors in the future (the repo is public so adding it should be free).

@asajatovic asajatovic merged commit ca6a77c into master Jul 26, 2021
@mariosasko mariosasko deleted the fix-windows-tests branch July 26, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants