fix: fetch metadata for immortal payloads (#1773)

* fix: fetch metadata for immortal payloads * fix: ignore block hash when estimating fees * fix: comment
TalismanSociety · Jan 8, 2025 · bef6a3c · bef6a3c
1 parent e720c76
commit bef6a3c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/apps/extension/src/ui/util/getExtrinsicDispatchInfo.ts b/apps/extension/src/ui/util/getExtrinsicDispatchInfo.ts
@@ -1,6 +1,5 @@
 import { GenericExtrinsic } from "@polkadot/types"
 import { assert } from "@polkadot/util"
-import { HexString } from "@polkadot/util/types"
 
 import { stateCall } from "./stateCall"
 
@@ -12,7 +11,6 @@ type ExtrinsicDispatchInfo = {
 export const getExtrinsicDispatchInfo = async (
   chainId: string,
   signedExtrinsic: GenericExtrinsic,
-  blockHash?: HexString,
 ): Promise<ExtrinsicDispatchInfo> => {
   assert(signedExtrinsic.isSigned, "Extrinsic must be signed (or fakeSigned) in order to query fee")
 
@@ -23,7 +21,7 @@ export const getExtrinsicDispatchInfo = async (
     "TransactionPaymentApi_query_info",
     "RuntimeDispatchInfo",
     [signedExtrinsic, len],
-    blockHash,
+    undefined,
     true,
   )
 

diff --git a/packages/extension-core/src/util/getMetadataDef.ts b/packages/extension-core/src/util/getMetadataDef.ts
@@ -55,6 +55,10 @@ const getMetadataDefInner = async (
 ): Promise<TalismanMetadataDef | undefined> => {
   const [chain, genesisHash] = await getChainAndGenesisHashFromIdOrHash(chainIdOrHash)
 
+  // blockHash being equal to genesisHash happens when trying to decode payload of immortal transactions
+  // in that case, blockHash must not be used as block reference when fetching data
+  if (blockHash && blockHash === genesisHash) blockHash = undefined
+
   const cacheKey = getResultCacheKey(genesisHash, specVersion)
   if (cacheKey && CACHE_RESULTS.has(cacheKey)) return CACHE_RESULTS.get(cacheKey)