Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cleanup #459

Merged
merged 4 commits into from
Dec 22, 2023
Merged

User cleanup #459

merged 4 commits into from
Dec 22, 2023

Conversation

tswfi
Copy link
Member

@tswfi tswfi commented Dec 22, 2023

Add few admin tools to help with marking the users
Add script (not crontabbed yet) for deleting marked users
Add tests for user deletion

@tswfi tswfi requested a review from olmari December 22, 2023 19:30
@tswfi
Copy link
Member Author

tswfi commented Dec 22, 2023

tox will fail until #458 gets merged and this PR rebased (because the tests were moved around)

@tswfi
Copy link
Member Author

tswfi commented Dec 22, 2023

@olmari rebased and now tox is happy

This doesn't have any functional changes, mainly the admin view has a new filter and bit different list items. And now that we have some tests I'm more confident on doing cleanup in the future automatically.

And I even think we could expose the mark_for_deletion_on as a user button "I want to end my hacklab membership" so that users can do it themself..

Copy link
Collaborator

@olmari olmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswfi tswfi merged commit 97f3869 into master Dec 22, 2023
1 check passed
@tswfi tswfi deleted the user_cleanup branch December 22, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants