Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-core): async form validator runs only if sync field & form passed #1029

Merged

Conversation

Balastrong
Copy link
Member

No description provided.

Copy link

nx-cloud bot commented Nov 19, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab4c57c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@1029

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@1029

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@1029

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@1029

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@1029

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@1029

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@1029

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@1029

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@1029

commit: ab4c57c

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (5473bb8) to head (ab4c57c).
Report is 167 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
- Coverage   91.55%   85.70%   -5.86%     
==========================================
  Files          21       28       +7     
  Lines         900     1098     +198     
  Branches      206      274      +68     
==========================================
+ Hits          824      941     +117     
- Misses         71      144      +73     
- Partials        5       13       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Balastrong Balastrong merged commit 362ce10 into TanStack:main Nov 19, 2024
6 of 7 checks passed
@Balastrong Balastrong deleted the fix/async-form-validator-after-sync branch November 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant