-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow standard schema validator on field validators without explicit adapter #1064
fix: allow standard schema validator on field validators without explicit adapter #1064
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df0fb00. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
- Coverage 86.70% 86.61% -0.09%
==========================================
Files 29 29
Lines 1158 1158
Branches 301 300 -1
==========================================
- Hits 1004 1003 -1
- Misses 141 142 +1
Partials 13 13 ☔ View full report in Codecov by Sentry. |
|
||
```tsx | ||
import { zodValidator } from '@tanstack/zod-form-adapter' | ||
import { z } from 'zod' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Balastrong maybe this line should have been kept, not it's not clear where the z
(from z.object()
and z.number()
is coming from if someone is unfamiliar with Zod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep definitely, wanna do a PR? Thanks!
was removed by accident in TanStack#1064
No description provided.