Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove touchedErrors, {touch: true} API (true by default), deprecate field.getValue #812

Merged
merged 6 commits into from
Jul 6, 2024

Conversation

crutchcorn
Copy link
Member

This PR:

  • Remove touchedErrors (instead, use form.state.isTouched && form.state.meta.errors.map())
  • Rename touch API to something closer to dontUpdateMeta and invert true default to false
  • Deprecate (not remove) field.getValue for public usage (was always intended for internal usage. Use field.state.value instead)

Fixes #660

Copy link

nx-cloud bot commented Jul 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16330f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@crutchcorn crutchcorn merged commit 4e4a3ae into main Jul 6, 2024
2 checks passed
@crutchcorn crutchcorn deleted the v1-refactors branch July 6, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking] Refactors prior to 1.x
1 participant