fix: replaceDeepEqual for objects created by Object.create

TanStack · Apr 30, 2024 · 3afbab5 · 3afbab5
1 parent 38be91f
commit 3afbab5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/query-core/src/__tests__/utils.test.tsx b/packages/query-core/src/__tests__/utils.test.tsx
@@ -73,6 +73,14 @@ describe('core/utils', () => {
 
       expect(isPlainObject(Object.create(Graph))).toBeFalsy()
     })
+
+    it('should return `false` for object with custom prototype', () => {
+      const CustomProto = Object.create({ a: 1 })
+      const obj = Object.create(CustomProto)
+      obj.b = 2
+
+      expect(isPlainObject(obj)).toBeFalsy()
+    })
   })
 
   describe('isPlainArray', () => {

diff --git a/packages/query-core/src/utils.ts b/packages/query-core/src/utils.ts
@@ -300,6 +300,11 @@ export function isPlainObject(o: any): o is Object {
     return false
   }
 
+  // Handles Objects created by Object.create(<arbitrary prototype>)
+  if (Object.getPrototypeOf(o) !== Object.prototype) {
+    return false
+  }
+
   // Most likely a plain Object
   return true
 }