fix: makeQueryCache config was not optional in the type def #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackmellis
force-pushed
the
fix/make-query-cache-optional-config
branch
from
e44d4ab to
d86187b
Compare
|
🎉 This PR is included in version 2.0.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm just trying out v2 while a lot of our code is in a non-release phase (not sure when you plan on fully releasing v2?), so happy to throw any PRs for bits and pieces.
This started as a single quick type fix but it's turned into a general "fix the types" PR...
enabledoption to the query optsforceflag from everywhere as it's no longer usedidleto the list of statusesQueryStatusas I was often having to manually writestatus: 'success' | 'loading' | 'error'when we're passing the status into other components