Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): unify & use noop #8294

Merged
merged 5 commits into from
Nov 15, 2024
Merged

refactor(*): unify & use noop #8294

merged 5 commits into from
Nov 15, 2024

Conversation

manudeli
Copy link
Contributor

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 15, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4c40c12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

manudeli
manudeli commented Nov 15, 2024
View reviewed changes
packages/query-core/src/utils.ts Outdated
Comment on lines 71 to 73
export function noop(): undefined {
return undefined
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unified this noop return type from undefined to void

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now @tanstack/query-core's noop's return type is undefined

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 15, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8294

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8294

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8294

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8294

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8294

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8294

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8294

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8294

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8294

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8294

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8294

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8294

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8294

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8294

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8294

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8294

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8294

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8294

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8294

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8294

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8294

commit: 4c40c12

@manudeli manudeli marked this pull request as ready for review November 15, 2024 03:23
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (923736c) to head (4c40c12).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8294       +/-   ##
===========================================
+ Coverage   45.84%   82.27%   +36.42%     
===========================================
  Files         199       81      -118     
  Lines        7499     1213     -6286     
  Branches     1714      256     -1458     
===========================================
- Hits         3438      998     -2440     
+ Misses       3683      186     -3497     
+ Partials      378       29      -349
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.25% <100.00%> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <100.00%> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister 82.50% <0.00%> (ø)
@tanstack/react-query 95.54% <33.33%> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <100.00%> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <100.00%> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@manudeli manudeli requested a review from TkDodo November 15, 2024 12:16
@manudeli
Copy link
Contributor Author

manudeli commented Nov 15, 2024 •
edited
Loading

I'll fix type error soon

@manudeli
Copy link
Contributor Author

I resolved it now😀

@TkDodo TkDodo merged commit 6c2a055 into TanStack:main Nov 15, 2024
8 checks passed
@TkDodo TkDodo mentioned this pull request Nov 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: angular-query-experimental package: query-async-storage-persister package: query-sync-storage-persister package: react-query package: solid-query package: svelte-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo