Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typescript 5.7 #8327

Merged
merged 12 commits into from
Nov 25, 2024
Merged

chore: typescript 5.7 #8327

merged 12 commits into from
Nov 25, 2024

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Nov 22, 2024

and run tests against ts 5.0 - 5.7

Copy link

nx-cloud bot commented Nov 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b07175. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Nov 24, 2024

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8327

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8327

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8327

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8327

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8327

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8327

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8327

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8327

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8327

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8327

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8327

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8327

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8327

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8327

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8327

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8327

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8327

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8327

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8327

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8327

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8327

commit: 2b07175

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.97%. Comparing base (ecc17d5) to head (2b07175).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8327   +/-   ##
=======================================
  Coverage   45.96%   45.97%           
=======================================
  Files         200      200           
  Lines        7508     7509    +1     
  Branches     1717     1716    -1     
=======================================
+ Hits         3451     3452    +1     
  Misses       3680     3680           
  Partials      377      377           
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 87.13% <100.00%> (ø)
@tanstack/eslint-plugin-query 88.17% <100.00%> (+0.02%) ⬆️
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 93.69% <ø> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.54% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.45% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
---- 🚨 Try these New Features:

Copy link
Member

@lachlancollins lachlancollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vue-tsc doesn't currently work with TS 5.7, so I've fixed it to 5.6: vuejs/language-tools#5018

@TkDodo TkDodo merged commit ef0b7b2 into main Nov 25, 2024
8 checks passed
@TkDodo TkDodo deleted the feature/ts-5.7 branch November 25, 2024 08:45
manudeli added a commit to toss/suspensive that referenced this pull request Dec 10, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

This PR upgrades to the newest stable version of typescript to align
with Tanstack query's version change
(TanStack/query#8327)



## PR Checklist

- [✅] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

---------

Co-authored-by: Jonghyeon Ko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment