-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: typescript 5.7 #8327
chore: typescript 5.7 #8327
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2b07175. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
and run tests against ts 5.0 - 5.7
1948b5b
to
9aaef2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8327 +/- ##
=======================================
Coverage 45.96% 45.97%
=======================================
Files 200 200
Lines 7508 7509 +1
Branches 1717 1716 -1
=======================================
+ Hits 3451 3452 +1
Misses 3680 3680
Partials 377 377
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vue-tsc doesn't currently work with TS 5.7, so I've fixed it to 5.6: vuejs/language-tools#5018
# Overview <!-- A clear and concise description of what this pr is about. --> This PR upgrades to the newest stable version of typescript to align with Tanstack query's version change (TanStack/query#8327) ## PR Checklist - [✅] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --------- Co-authored-by: Jonghyeon Ko <[email protected]>
and run tests against ts 5.0 - 5.7