Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react-query): Simplify useQueries #8661

Merged
merged 2 commits into from
Feb 18, 2025
Merged

refactor(react-query): Simplify useQueries #8661

merged 2 commits into from
Feb 18, 2025

Conversation

jordan-choi
Copy link
Contributor

This is a follow-up to #8593. This reuses an already defined variable and avoids the need to use optional chaining because the code is already checking for query being defined:

query/packages/react-query/src/useQueries.ts

Lines 332 to 334 in 044acae

const query = defaultedQueries[index]
return (
query &&

@jordan-choi jordan-choi changed the title refactor: Simplify useQueries refactor(react-query): Simplify useQueries Feb 17, 2025
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 98bbdb1.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 14s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 33s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 13:52:37 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 18, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8661

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8661

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8661

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8661

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8661

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8661

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8661

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8661

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8661

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8661

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8661

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8661

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8661

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8661

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8661

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8661

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8661

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8661

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8661

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8661

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8661

commit: 98bbdb1

@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (56183f0) to head (98bbdb1).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8661       +/-   ##
===========================================
+ Coverage   46.28%   84.05%   +37.76%     
===========================================
  Files         199       26      -173     
  Lines        7549      370     -7179     
  Branches     1733      108     -1625     
===========================================
- Hits         3494      311     -3183     
+ Misses       3675       50     -3625     
+ Partials      380        9      -371
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 95.37% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit caf7bde into TanStack:main Feb 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordan-choi @TkDodo