-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Serialization Paradigm #1824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3b35e77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
I'm not completely sure how to get things passing without forcing the entire monorepo into React 19... |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
packages/router-plugin/tests/code-splitter/test-files/function-as-parameter.tsx
Show resolved
Hide resolved
tannerlinsley
commented
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defer(promise)
is no longer needed, since we are walking the loader return and extracting promises and streams now.Await
is still required in React <19 to consume deferred promises, but in 19,use
will work just fine.createStartHandler
. More work is needed for non-start SSR envs to use it, which is wherecreateRequestHandler
needs some more polish.temp-
entries there for what I know worksrenderRsc
function, exported from@tanstack/start
, which uses the newreact-server-dom/client
to isomorphically create React elements from either Readable's on the server or ReadableStreams/Fetches on the client. One of the reasons for thisrenderRsc()
step is so that RSCs remain primitive streams until they can be handled by the router for SSR and caching, after which they are released back to the user via useLoaderData for consumption. Diving deeper, the primary reason for this is so that we can gain access to the original binary chunks of RSC syntax that are being streamed across the wire. Without access to those chunks, we cannot serialize and recreate the RSC across any serialization boundary.useState
, etc. I still have strong feelings that these imports shouldn't be invariants during bundling and should only warn at runtime... but I digress..tsr-once
class to ensure than an element is completely removed before hydration is attempted.