fix(table-core): column getCanGroup always resolving to true (#4843)

* Fix getCanGroup always resolving to true * fix column.getCanGroup --------- Co-authored-by: Phil Morris <[email protected]> Co-authored-by: Kevin Van Cott <[email protected]>
TanStack · Mar 29, 2024 · fce4725 · fce4725
1 parent c6b2507
commit fce4725
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/table-core/src/features/ColumnGrouping.ts b/packages/table-core/src/features/ColumnGrouping.ts
@@ -283,11 +283,9 @@ export const ColumnGrouping: TableFeature = {
 
     column.getCanGroup = () => {
       return (
-        column.columnDef.enableGrouping ??
-        true ??
-        table.options.enableGrouping ??
-        true ??
-        !!column.accessorFn
+        (column.columnDef.enableGrouping ?? true) &&
+        (table.options.enableGrouping ?? true) &&
+        (!!column.accessorFn || !!column.columnDef.getGroupingValue)
       )
     }