Add useRowSpan plugin #2534
Add useRowSpan plugin #2534
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-table/fut2e29kf |
|
I'd like to build this into the core in the |
|
Sure! I believe the only thing I was still working through is getting it to
not crash on sort.
…On Mon, Aug 3, 2020, 1:30 PM Tanner Linsley ***@***.***> wrote:
I'd like to build this into the core in the next branch. You up for that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCCD6DMR6UOK2C3CSDHLQTR63XZ7ANCNFSM4OZ3CMMQ>
.
|
|
@liberza I'm curious if this plugins work fine with React-virtualized since validateDOM is always throwing errors due to the HoC being a div. |
|
Great question, that's actually a problem I haven't solved yet with
rowspan. Seems pretty tricky with react-window, but virtuoso may mostly
just work with this.
I had looked a bit into how Autodesk's table library does rowspan +
virtualization, but it appeared that they weren't doing "real" rowspan with
the html attribute.
…On Sun, Aug 9, 2020, 2:52 PM Enigma ***@***.***> wrote:
@liberza <https://github.com/liberza> I'm curious if this plugins work
fine with React-virtualized since validateDOM is always throwing errors due
to the HoC being a div.
Have you tested this with any kind of virtualization? I'm looking forward
for row span but has to support virtualize
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCCD6FFB4UHZKQFCEGNRB3R73V5LANCNFSM4OZ3CMMQ>
.
|
|
@liberza Yup i have checked Autodek's too but i really prefer react-table API but this comes to a need having virtualization with row spans, now i can't use row span html attribute because my HoCs are divs and React naturally can't handle that nested DOM validation. |
Ah, yes for my use case I've relied on |
|
@liberza I'm just looking for because virtualize does not work with natural td, in case you have thousands of rows like in my use case, somethings you need to do the heavy lifting of calculating what might be on the screen of not. Let's say you have a merge that has 400childs and the screen can only display 50, i will chunk it and not display everything otherwise the whole merge parent has to be rendered, and naturally, with HTML rowspan it's going to get rendered. |
|
@tannerlinsley Any news on this? |
|
Again, I think it's going to be easier and better if we just slate this for v8. When things are ready, I'll ping here for the PR to be reopened, but pointed at the next branch. |
|
@underfisk in case interested to make this plugin available for v7, feel free to PR it at https://github.com/gargroh/react-table-plugins, in this repo we are maintaining all non-core v7 plugins, till the time they are available in v8. |
|
@gargroh Thanks for mentioning that package, unfortunately, i have decided to start creating my own plugin to solve my needs and so far its going pretty well which is a pity, i kinda liked how React table is organized because it is indeed scalable |
|
@tannerlinsley so is there a way to make rowspan with v8? |
|
I'm interested to know if I can do rowspan with v8 |
This PR adds a new plugin, useRowSpan. The plugin sets a rowSpan attribute on duplicate cells, and provides the spanned rows to the user via the cell object.
Not complete yet - needs test, example, & docs.