Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Ingredients / food #1191

Closed
TWART016 opened this issue Dec 31, 2021 · 15 comments
Closed

rename Ingredients / food #1191

TWART016 opened this issue Dec 31, 2021 · 15 comments
Labels
bug Something isn't working

Comments

@TWART016
Copy link

Version

Version: 1.0.4

Bug description

In the right top menu the topic is called ingredients
image

Inside this topic it is called foods
image

The same name would be great.

@vabene1111 vabene1111 added the bug Something isn't working label Jan 2, 2022
@vabene1111
Copy link
Collaborator

thanks for the issue, will fix in the next release

@shadrqen
Copy link

shadrqen commented Jan 2, 2022

@vabene1111 This looks like a great first issue for me. Would you mind if I get started with this?

@vabene1111
Copy link
Collaborator

Sure, take a Crack, shouldn't be too Hard :)

@shadrqen
Copy link

shadrqen commented Jan 2, 2022

Great.

@vabene1111
Copy link
Collaborator

i just fixed this as i had the file open anyway, and i wasn't sure if you would still do it, but thank you for trying. feel free to take a crack at any issue, just let us now below it :)

@TWART016
Copy link
Author

Inside the recipe there is still Ingredients. Is that wanted?

@smilerz
Copy link
Collaborator

smilerz commented Jan 12, 2022

Inside the recipe there is still Ingredients. Is that wanted?

Yes. Ingredients are an amount, a unit, a food and a note

@TWART016
Copy link
Author

Inside the recipe there is still Ingredients. Is that wanted?

Yes. Ingredients are an amount, a unit, a food and a note

I mean in the menu changed the name from ingredients to food. Here is still the old name.

@smilerz
Copy link
Collaborator

smilerz commented Jan 12, 2022

They are ingredients. Not food.

@TWART016
Copy link
Author

vabene1111 changed the name in menu from ingredients to food
#1191 (comment)

Inside a recipe the colum named Food and the headline is Ingredients
image

What is the difference between these two?

@smilerz
Copy link
Collaborator

smilerz commented Jan 12, 2022

an ingredient is the union of amount/unit/food, the food is just what you put in your mouth.

@vabene1111
Copy link
Collaborator

its a little confusing but it is right. The table in the recipe is actually the list of ingredients (which are as smilerz said the union of all elements that make up an ingredient). A food is part of the ingredient tuple. Since the menu brings you to the list of foods it is now correctly named foods, the recipe editor allows you to edit actual ingredients thus the header there is right too.

But thanks for reporting :)

@shadrqen
Copy link

shadrqen commented Jan 17, 2022

@vabene1111 I'm sorry couldn't install the app. Had an issue with the database, and later the webpack-stats.json issue described in #1209 However, I've been able to run it successfully by using the vabene111/recipes image instead of building docker locally. I guess I'll be in a position to help now? Thank you.

@TWART016
Copy link
Author

In Search the name with Use Tree Selection enabled is still Ingredients.

And I think the font-size and box size is different.

image
image

@smilerz
Copy link
Collaborator

smilerz commented Jan 27, 2022

I don't have an answer for that one - they are using identical placeholder values.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants