PDF export improvement #1281
Merged
PDF export improvement #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a rather large PR and also change to the way exports work, i will need to properly review this once i am back home. Does this also add a loading page to all other exporters so that all of them profit from this workflow ? |
|
Yes the loading page is for all of the exporters |
|
as this is a little larger and requires some testing i will try to get the next version out and merge this then, hope you are ok with that |
|
merging this now onto a feature branch and fixing the issues myself, thanks for providing all the foundations to get this working. |
|
Ok, great. |
|
ok only thing left now is the step images/files but those are not supported by the other exporters as well so we will need to tackle that in its own go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to recreate the await issue.
However I was able to find that when exporting large amount of recipes:
The page would timeout: fixed by adding a loading page similar to import
Pyppeteer goto() would timeout: fixed by creating the page in the recipe loop
To improve the speed, pyppeteer now wait for a selector instead of networkidle0
The export filename has the date appended to it; in YYYY-MM-DD format for it to be in sorted order in the users file directory
#1211