Keep screen awake when viewing recipe #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, thanks for implementing this. I need to review this since i dont know much about this function but i am pretty sure it should work. Since i have my phone never turn off i never even noticed that this is a problem 😂 |
|
ok just checked the vue lifecylcle docs, beforeUnmount seems to be a vue 3 lifecycle hook so i changed that to beforeDEstory, otherwise this seems correct, thanks for the contribution! |
|
ok it appears that this is indeed available in v2 as well but not in the docs .. ok staying with unmount then .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #1434
This is rather basic, at some point you could add a switch to toggle this functionality on & off.