Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated .dockerignore #1472

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

smilerz
Copy link
Collaborator

@smilerz smilerz commented Feb 2, 2022

ignore node_modules at every directory depth
ignore .vue and .ts files
ignore mediafiles/staticfiles/sqlitedb
ignore pytest configs/folders
ignore openapi generator

@MaxJa4
Copy link
Contributor

MaxJa4 commented Feb 2, 2022

Very nice, I'm excited to see the docker image size difference with this optimization :)

@smilerz
Copy link
Collaborator Author

smilerz commented Feb 2, 2022

Very nice, I'm excited to see the docker image size difference with this optimization :)

based on anecdotal evidence it got cut about 50%

@vabene1111
Copy link
Collaborator

thats quite a lot ... but it makes sense, node modules is gigantic and it wasn't a problem before we moved the node build to the build process but when we did that i forgot to update .dockerignore

thanks :)

@vabene1111 vabene1111 merged commit ed99da2 into TandoorRecipes:develop Feb 3, 2022
@MaxJa4
Copy link
Contributor

MaxJa4 commented Feb 3, 2022

1.0.5: 181.54 MB / 743.5 MB (compressed / uncompressed)
1.0.6: 101.62 MB / 351.4 MB (compressed / uncompressed)
-> ~44% / ~53% size reduction. Pretty good guess smilerz :) Awesome!

@smilerz smilerz deleted the updated_dockerignore branch February 14, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants