Ping DB instead of trying migration #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
postgresql-client also has pg_isready and is quite a bit smaller than the whole postgresql package. Will test and change. |
|
Installation size of postgresql: 32.11 MB Tested and worked flawlessly for me. |
|
awesome, thats really cool, thanks for making this better :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1498 I added a retry functionality for the migration.
Since blindly retrying migrations can be dangerous since I'd see it as blindly messing with data, knowing something isn't right, I decided to look for a better solution (and also reduce log spam drastically).
With this, the PostgreSQL server in POSTGRES_HOST (e.g. db_recipes) will be pinged before migration.
The only downside to this is the necessity to add postgresql as additional dependency which increases image size slightly.
If someone knows another way to get access to the pg_isready command, please let me know.