Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow signup for social accounts when the provider is set up #2593

Merged
merged 2 commits into from
Sep 12, 2023
Merged

allow signup for social accounts when the provider is set up #2593

merged 2 commits into from
Sep 12, 2023

Conversation

BrainWart
Copy link
Contributor

When a social provider is set up, the social account signup view is enabled. This seems to cover issue #2261, but it needs further testing.

@vabene1111
Copy link
Collaborator

thanks for your PR. this changes the logic for existing setups but I think this is a rather expected behavior so we can probably safely change it.

To get this merged we need to

  • verify if there are any tests testing this behavior, maybe add some if not
  • explain the behavior in .env.template
  • explain the behavior in the docs if there is any applicable section

if you want you could do that, if not I will need to do it when I have time and merge it then,

@BrainWart
Copy link
Contributor Author

Thank you for creating this project!

To get this merged we need to

  • verify if there are any tests testing this behavior, maybe add some if not

I am not sure if I will be able to handle this, but I am happy to give it a shot. I am not really much of a Python developer.

  • explain the behavior in .env.template

Will do

  • explain the behavior in the docs if there is any applicable section

I can do this as well.

Thank again!

When a social provider is set up, the social account signup view is enabled. This seems to cover issue #2261, but it needs further testing.
Attempt to explain to the user that social auth with automatically allow
users to sign up for social accounts. `ALLOW_SIGNUP` now applies to
local account sign up only.
@BrainWart
Copy link
Contributor Author

BrainWart commented Aug 30, 2023

@vabene1111,
I did not see any relevant tests or any easy way to ensure the social sign up buttons appear under the expected conditions. If possible, could you provide some guidance for testing for this change?

I have rebased this pull request on the changes present at the time of writing this comment.

@vabene1111
Copy link
Collaborator

hi @BrainWart thanks for making the changes. I am not entirely sure how to do the test, I would probably test the function itself not the view/html, but dont worry about that if this is not your main thing, I can look at it at the time of merging (or decide I am to lazy 😂)

@vabene1111 vabene1111 added this to the 1.5.0 milestone Aug 30, 2023
@BrainWart
Copy link
Contributor Author

Sounds good. I appreciate the work you're doing with this project. Thank you

@vabene1111 vabene1111 merged commit 83a52bd into TandoorRecipes:develop Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants