Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loot Tweaks #273

Merged
Merged

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Jul 9, 2023

Description

  • Stopped "Fixed" capacitor modifiers from being generated as loot.
  • Fixed loot capacitors not storing stats on multiplayer (Breaking: old loot capacitors will reset).
  • Loot capacitors have a small chance of generating with more than one modifier.

Now includes near enough similar chest loot entries for the overworld, will need another pass when we have more content, but its enough to keep us going.

Todo

  • Confirm loot changes
  • Add other loot entries
  • Spawn loot in more places

Closes #238

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Rover656 Rover656 added Type-Bug There is a problem. Type-RFC Request for comments. MC-1.20.1 labels Jul 9, 2023
@Rover656 Rover656 added this to the The Great Squashening milestone Jul 9, 2023
Copy link
Member Author

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also going to look at adding the other missing loot tables entries from 1.12.2

@Rover656 Rover656 changed the title Loot Capacitor Tweaks Loot Tweaks Jul 9, 2023
@Rover656 Rover656 marked this pull request as draft July 10, 2023 21:24
@Rover656 Rover656 changed the base branch from dev/1.20.1 to release/1.20.1 July 26, 2023 11:15
@Rover656 Rover656 changed the base branch from release/1.20.1 to dev/1.20.1 July 27, 2023 22:09
@Rover656 Rover656 marked this pull request as ready for review July 28, 2023 19:06
@Rover656 Rover656 merged commit 2e4295b into Team-EnderIO:dev/1.20.1 Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MC-1.20.1 Type-Bug There is a problem. Type-RFC Request for comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Loot capacitors have invalid modifier
2 participants