Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Range code to common Machine block class #362

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Move Range code to common Machine block class #362

merged 6 commits into from
Jul 30, 2023

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Jul 27, 2023 •
edited
Loading

Description

Move the range code to a common class to avoid duplicate code.

Closes #(issue)

Todo

  • Fix syncing...

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@ferriarnus ferriarnus marked this pull request as ready for review July 27, 2023 12:24
Rover656
Rover656 approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks ferri :shipit:

@Rover656 Rover656 merged commit 9060182 into Team-EnderIO:dev/1.20.1 Jul 30, 2023
@ferriarnus ferriarnus deleted the rangecode branch August 16, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rover656 Rover656 Rover656 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferriarnus @Rover656