Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Enchantment Descriptions. #414

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Aug 2, 2023

Description

Uses the enchantment descriptions mod instead of rolling our own.
Continues to display the tool types for the withering enchantments.
Also changes our tooltips to aqua to make them clearer and removes shift to show on capacitors, as you will more likely want to see the values than not.

image
image
image

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Uses the enchantment descriptions mod instead of rolling our own.
Continues to display the tool types for the withering enchantments.
@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. Area-Mod Compat MC-1.20.1 P-2-Low Low priority. Not hurting anyone, just annoying. labels Aug 2, 2023
justliliandev
justliliandev previously approved these changes Aug 3, 2023
Copy link
Contributor

@justliliandev justliliandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, if we want to merge the Wither Enchantments we might want to do that here too

@ferriarnus
Copy link
Member

We could, but I think vanilla doesn't have a combined category for arrows and bolts. Though looking at the code I messed up and bolts aren't actually bolts, they also use arrow...

@Rover656 Rover656 merged commit fb3a74e into dev/1.20.1 Aug 4, 2023
@Rover656 Rover656 deleted the feature/enchantment-descriptions branch August 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Mod Compat MC-1.20.1 P-2-Low Low priority. Not hurting anyone, just annoying. Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants