[7.2] Full Conduit Rework/Revisit #958
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rover656
added
Area-Backend
Rover656
force-pushed
the
chore/conduit-connections
branch
2 times, most recently
from
7c5d8d8 to
f13213b
Compare
Rover656
changed the title
Rover656
force-pushed
the
chore/conduit-connections
branch
from
3e7b27a to
aba81ea
Compare
Still need to address many TODOs and GUI
- Tested a possible accessibility improvement - Copied over clone item stack - Aiming shapes now only show the conduit you're aiming at, rather than outlining the entire bundle stuff. - Fixed facades not working (sync and model issues) - Override particles for bundles due to a crash - need to implement this properly - Facades can now be placed standalone, without the need for an existing bundle. - Fixed a crash when breaking an RS node
I'm not interested in documenting all the work and in progress changes here
…he messy getShape I did
Also optimised redstone conduit updates a bit.
Rover656
force-pushed
the
chore/conduit-connections
branch
from
73a36c3 to
32925d2
Compare
Also re-added logic for redstone input filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an entire-system overhaul for conduits, bringing back as many missing 1.12 features as I can and making sure conduits are as polished as they can be.
This PR will not include the visual redesign of the block or the UI, and as such will strive for parity with previous versions of the GUI/block.
This PR is not ready for feedback :)
Breaking Changes
List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.
Major API breaks for mods that add or interact with conduits.
Has supporting logic for loading existing conduit bundles, but it is not saved in a backward-compatible format (i.e. 7.2 cannot be safely downgraded from)
Checklist