Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿš€ ๋ฉ”์ดํŠธ ์ฐธ์—ฌ ์‚ญ์ œ API ๊ตฌํ˜„ #142

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

IjjS
Copy link
Contributor

@IjjS IjjS commented Mar 19, 2024

๐ŸŽซ ๊ด€๋ จ ์ด์Šˆ

๐Ÿš€ ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • DELETE /api/v1/mates/{id}/participants/{participantId}
  • ๋ฉ”์ดํŠธ ์ฐธ์—ฌ ๊ฑฐ์ ˆ/์ทจ์†Œ -> ๋ฉ”์ดํŠธ ์‚ญ์ œ
  • ์ด๋ฏธ ์—†๋Š” ๋ฐ์ดํ„ฐ์ผ ์‹œ ์˜ˆ์™ธ ๋ฐœ์ƒ โŒ
  • validator ๋“ฑ ์ด๋ฏธ ๊ตฌํ˜„ํ•œ๊ฒŒ ์žˆ์–ด์„œ ๋‹ค๋ฅธ ๋ธŒ๋žœ์น˜๋ฅผ ํ—ค๋”ฉํ•ด์„œ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋จธ์ง€ํ•  ๋• ์ˆœ์ฐจ์ ์œผ๋กœ ์ง„ํ–‰ํ• ๊ฒŒ์š”!

๐Ÿ’ก ๊ธฐํƒ€์‚ฌํ•ญ

  • ๊ฑฐ์ ˆ/์ทจ์†Œ/๋ฌด์‹œ ๋“ฑ ์ƒํƒœ๋ฅผ ์„ธ๋ถ€์ ์œผ๋กœ ๋Š˜๋ฆฌ๊ณ  ์ง„ํ–‰ํ•˜๋Š” ๋ฐฉํ–ฅ๋„ ์žˆ์ง€๋งŒ ์ผ๋‹จ ์‚ญ์ œ๋กœ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค
  • ์ฐธ์—ฌ์ž ์ƒํƒœ๊ฐ€ enum์ด๋‹ˆ ๋‚˜์ค‘์— ์ƒํƒœ ๋ณ„ ์•ก์…˜์ด ์ถ”๊ฐ€๋œ๋‹ค๋ฉด ๊ทธ ๋•Œ api๋ฅผ ์ƒˆ๋กœ ๋งŒ๋“ค์–ด๋„ ๋œ๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”

@IjjS IjjS added โœ…ย Feature ์ƒˆ์นœ๊ตฌ~! ๐Ÿ’ฃ ์ „์‹œ ์ƒํ™ฉ!!! ๋‹น์žฅ ์กฐ์น˜๊ฐ€ ํ•„์š”ํ•จ (๋‹น์ผ ๋ฆฌ๋ทฐ) labels Mar 19, 2024
@IjjS IjjS self-assigned this Mar 19, 2024
@IjjS IjjS requested a review from a team as a code owner March 19, 2024 06:12
@IjjS IjjS requested review from ASak1104 and shoeone96 and removed request for a team March 19, 2024 06:12
Copy link

github-actions bot commented Mar 19, 2024

๐Ÿ“‘ Jacoco ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

Overall Project 82.15% -0.1% ๐Ÿ
Files changed 85% ๐Ÿ

File Coverage
MateValidator.java 100% ๐Ÿ
MateService.java 93.1% ๐Ÿ
MateParticipantController.java 0% -26.47% โŒ

Copy link
Contributor

@ASak1104 ASak1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

204๋กœ ๊ณ ์ •ํ•˜๋Š” ๊ฒƒ๋ณด๋‹ค 404 ๋‚ด๋ณด๋‚ด๋Š” ๊ฒƒ๋„ ์ข‹์€ ๊ฒƒ ๊ฐ™์€๋ฐ์š”?

Copy link
Contributor

@shoeone96 shoeone96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์–ด์š”!

Base automatically changed from feature-accept-participant to feature March 19, 2024 14:41
@IjjS IjjS requested a review from ASak1104 March 19, 2024 14:42
@shoeone96 shoeone96 merged commit fd209af into feature Mar 20, 2024
1 check passed
@shoeone96 shoeone96 deleted the feature-delete-participant branch March 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœ…ย Feature ์ƒˆ์นœ๊ตฌ~! ๐Ÿ’ฃ ์ „์‹œ ์ƒํ™ฉ!!! ๋‹น์žฅ ์กฐ์น˜๊ฐ€ ํ•„์š”ํ•จ (๋‹น์ผ ๋ฆฌ๋ทฐ)
Projects
Status: Done
3 participants