Merge branch '1.20.2' of D:\Repos\Minecraft\SFM\repos\SuperFactoryMan…

…ager 1.20.2 into 1.20.3
TeamDman · Jun 26, 2024 · c3fc673 · c3fc673
2 parents 021919b + 8148434
commit c3fc673
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/ca/teamdman/sfm/common/net/ClientboundManagerLogsPacket.java b/src/main/java/ca/teamdman/sfm/common/net/ClientboundManagerLogsPacket.java
@@ -29,7 +29,9 @@ public static void encode(
     ) {
         friendlyByteBuf.writeVarInt(msg.windowId());
         friendlyByteBuf.writeVarInt(msg.logsBuf.readableBytes());
-        friendlyByteBuf.writeBytes(msg.logsBuf);
+        friendlyByteBuf.writeBytes(msg.logsBuf, 0, msg.logsBuf.readableBytes()); // !!!IMPORTANT!!!
+        // We use this write method specifically to NOT modify the reader index.
+        // The encode method may be called multiple times, so we want to ensure it is idempotent.
     }
 
     public static ClientboundManagerLogsPacket decode(FriendlyByteBuf friendlyByteBuf) {