Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast notification to enqueue a playlist #9130

Closed
6 tasks done
killerrook opened this issue Oct 14, 2022 · 7 comments · Fixed by #9196
Closed
6 tasks done

Toast notification to enqueue a playlist #9130

killerrook opened this issue Oct 14, 2022 · 7 comments · Fixed by #9196
Assignees
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app

Comments

@killerrook
Copy link

killerrook commented Oct 14, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

display a 'hold to enqueue' toast notification when either one of the headers(background, play all, popup) in a playlist is clicked to make users aware of enqueue feature just as a text is displayed when clicking background play on any video.

Why do you want this feature?

I believe this information should have been mentioned somewhere or this option should be given when long pressing on a playlist. Too hard to figure it out by a NORMAL user easily just by mere looking at it.

Additional information

No response

@killerrook killerrook added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 14, 2022
@opusforlife2 opusforlife2 added GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Oct 14, 2022
@killerrook killerrook reopened this Oct 15, 2022
@Jfax510
Copy link
Contributor

Jfax510 commented Oct 18, 2022

Hi, can I work on this issue?

@killerrook
Copy link
Author

@Jfax510 absolutely open a pull request whenever free just make sure to mention this issue like #9130 in description. If possible include screenshots of before and after. The title should be fix Toast notification to enqueue a playlist. Good luck

@killerrook
Copy link
Author

@SameenAhnaf could you please assign this issue to jfax510. Check message above for reference.

@SameenAhnaf
Copy link
Collaborator

@Master2050 You don't need to at mention team members for any specific action. The team members are aware of any change in the repo and one of them will definitely take care of it.

@killerrook
Copy link
Author

Thanks for letting me know and thanks for contributing your valuable time and effort to this project

@opusforlife2
Copy link
Collaborator

absolutely open a pull request

@Master2050 I mentioned this to another user a few days ago. Since you're not a team member, you can't be the one telling people it's okay to open a PR. If their PR is rejected by the team later, the responsibility will partially fall on you for the time they wasted. Let the team handle these things, okay?

@killerrook
Copy link
Author

Well I said the same thing above (see the chat above for reference) that I won't be commanding people from now on. Just trying to help out here

@opusforlife2 opusforlife2 added the playlist Anything to do with playlists in the app label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface playlist Anything to do with playlists in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants