[Youtube] Mark members-only videos #1280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YouTube inserts members-only videos (i.e., videos that require channel membership to watch) into the Videos tab. Because the extractor unable to distinguish between them and "normal" videos, they may appear in subscriptions feeds. This enables the extractor to check if videos require membership, allowing clients to filter them. Ref: TeamNewPipe/NewPipe#12040 Ref: TeamNewPipe/NewPipe#12011
Stypox
approved these changes
Feb 21, 2025
ShareASmile
added
enhancement
FineFindus
commented
Feb 21, 2025
There was a problem hiding this comment.
Thinking about it a bit more, maybe it makes sense to rename requiresMembership to isPaidContent (or something similar)? That would keep the naming consistent with the PaidContentException that is already thrown for member only content, and it would be generic enough for other services to use. But I'm not sure if that might conflict with something else, e.g. premium videos?
FineFindus
added a commit
to FineFindus/NewPipe
that referenced
this pull request
Mar 2, 2025
YouTube has started to mix members-only videos into the normal videos in the Videos tab. This filters them, as they cannot be watched without an account, leading to clutter in the feed. Requires TeamNewPipe/NewPipeExtractor#1280. Closes: TeamNewPipe#12011 Closes: TeamNewPipe#12040
FineFindus
added a commit
to FineFindus/NewPipe
that referenced
this pull request
Mar 2, 2025
YouTube has started to mix members-only videos into the normal videos in the Videos tab. This filters them, as they cannot be watched without an account, leading to clutter in the feed. Requires TeamNewPipe/NewPipeExtractor#1280. Closes: TeamNewPipe#12011 Closes: TeamNewPipe#12040
5 tasks
|
What about tests? Is it possible to create tests for the new extractions? |
|
I'm honestly a bit overwhelmed with how to create tests for static class MembersOnlyVideos extends DefaultListExtractorTest<ChannelTabExtractor> {
private static YoutubeChannelTabExtractor extractor;
@BeforeAll
static void setUp() throws IOException, ExtractionException {
YoutubeTestsUtils.ensureStateless();
NewPipe.init(DownloaderFactory.getDownloader(RESOURCE_PATH + "membersOnlyVideos"));
extractor = (YoutubeChannelTabExtractor) YouTube.getChannelTabExtractorFromId(
"@TheLinuxEXP", ChannelTabs.VIDEOS);
extractor.fetchPage();
}
@Override public ChannelTabExtractor extractor() throws Exception { return extractor; }
@Override public StreamingService expectedService() throws Exception { return YouTube; }
@Override public String expectedName() throws Exception { return ChannelTabs.VIDEOS; }
@Override public String expectedId() throws Exception { return "UC5UAwBUum7CPN5buc-_N1Fw"; }
@Override public String expectedUrlContains() throws Exception { return "https://www.youtube.com/channel/UC5UAwBUum7CPN5buc-_N1Fw/videos"; }
@Override public String expectedOriginalUrlContains() throws Exception { return "https://www.youtube.com/@TheLinuxEXP/videos"; }
@Override public boolean expectedHasMoreItems() { return true; }
@Test
@Override
public void testRelatedItems() throws Exception {
final List<StreamInfoItem> allItems = extractor.getInitialPage().getItems()
.stream()
.filter(StreamInfoItem.class::isInstance)
.map(StreamInfoItem.class::cast)
.collect(Collectors.toUnmodifiableList());
final List<StreamInfoItem> membershipVideos = allItems.stream()
.filter(item -> !item.requiresMembership())
.collect(Collectors.toUnmodifiableList());
assertTrue(membershipVideos.size() <= allItems.size());
}
}logAnd just checking if there are |
|
Note about tests: When writing a channel extractor test the channel should be chosen very carefully. I think it's best to chose a channel here that either
Maybe as an alternative a playlist can also be considered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube inserts members-only videos (i.e., videos that require channel membership to watch) into the Videos tab. Because the extractor unable to distinguish between them and "normal" videos, they may appear in subscriptions feeds.
This enables the extractor to check if videos require membership, allowing clients to filter them.
Ref: TeamNewPipe/NewPipe#12040
Ref: TeamNewPipe/NewPipe#12011