Pass additional regexes to youtube extractor

[nik-vanderveen]

• I carefully read the contribution guidelines and agree to them.
• I did test the API against NewPipe.
• I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

Adds support for passing additional regexes (from file, server, etc.) through youtube's extractor in order to fix extraction errors without an update. Closes #255

[TobiGr]

Thank you. Is there a reason why @nik-vanderveen creates a PR from @CWftw's repo?

[CWftw]

Thank you. Is there a reason why @nik-vanderveen creates a PR from @CWftw's repo?

I am CWftw and I approve this message (and this PR)

[TobiGr]

You could

• rename decryptionFuncNameRegexes to hardCodedDecryptionFuncNameRegexes
• rename allRegexes to decryptionFuncNameRegexes
• add a JDoc comment to the new constructor for YoutubeService and state, that additionalRegexes is thought to provide more regexes for private String getDecryptionFuncName(String playerCode) throws DecryptException.

But before you do this, I'd like to hear @wb9688's or/and @Stypox's opinion on this

[B0pol]

It has both a benefits and downsides:
👌 people will be able to add the regex found somewhere in settings, as a workaround before update when youtube has broken something
👍 less people would leave NewPipe due to it being broken
👎 people will be able to stay on an old version, without the other bug fixes…

I'm totally for this possibility.

[opusforlife2]

Have you guys discussed how this should be presented to the user?

My instinct as a user is to basically have a tappable option in settings to download additional regexes which you could host on the Newpipe website. All it would do is present a toast whether the download succeeded or failed, and people should see their videos opening again.

Where the downloaded file goes is inconsequential to the end user, though it should probably be part of the app's internal storage so that even if a user doesn't grant storage permission to Newpipe, the functionality doesn't break.

[litetex]

I'm closing this for now:

• no progress since over a year
• merge conflicts
• PR is in the current form no longer applicable. There have been massive reworks in the Extractor in the meantime (e.g. [YouTube] Use the new internal API in NewPipe Extractor #604) and the suggested fixes with the regex e.g. won't solve [YouTube] Fix buffering by decoding n parameter of stream urls #683

Feel free to reopen when there is progress again