[GET] /notice/service?lastid=&size= 서비스 알림 조회 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngkwon02
added
🦋 영권
Enhancement ✨
youngkwon02
changed the title
youngkwon02
changed the title
xxeol2
reviewed
Jan 12, 2022
Comment on lines
27
to
37
| for (let i = 0; i < services.length; i++) { | ||
| const service = services[i]; | ||
| const notice = { | ||
| noticeId: service.notificationId, | ||
| noticeTitle: service.title, | ||
| noticeImg: service.thumbnail, | ||
| noticeContent: service.content, | ||
| createdAt: service.createdAt.toISOString().split('T')[0].replace(/-/g, '/'), | ||
| }; | ||
| notices.push(notice); | ||
| } |
There was a problem hiding this comment.
for문대신 .map 을 사용해도 좋을 것 같아 보여요!
There was a problem hiding this comment.
@xxeol2
map 사용해서 리팩터링 완료했는데, 잘 적용한건지 모르겠네요~!
감사합니당 :)
혹시 더 좋은 사용법 있으면 공유 부탁드려요!!! 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Default Checklist
check branch
set Labels
set Reviewers
📕 Task
서비스 알림 테스트 데이터 생성
서비스 알림 조회 API
서비스 알림 조회 with Pagination