Sync Changes #23
Open
Sync Changes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lifted from Tachiyomi and adapted for Telethon. See: https://github.com/tachiyomiorg/tachiyomi/blob/master/.github/ISSUE_TEMPLATE/report_issue.yml
Noticed in #4123.
It was overcomplicated and had some subtle bugs. Closes #4133.
The server should instead fail with proper RPC errors, as the rules could change any time (and the local checks get out of date).
Likely temporary server issues, since getDifference should realistically not fail with flood waits. In any case, stopping early until the problem is resolved is the correct approach.
The library will behave the same, but the log severity is lowered.
Otherwise the unpacking done later won't work.
Only works with %-style formatting, but not in the logging module.
The sign_up method was deprecated in 07a7a8b and removed from the documentation, but since the method technically still exists (even though it immediately raises ValueError), that broke a test.
This has been broken since bd11564.
Introduced on accident by #4475.
This fixes image compression with mode "P" (potentially others) which is necessary as the server has erroneous alpha color with some types of images (mode "P" for example). This also properly applies the background argument that may be passed to _resize_photo_if_needed by always compressing images with alpha regardless of whether the server will compress the image for us.
drop_author is already supported but is undocumented. drop_media_captions for consistency with drop_author being implemented.
This also allows utils.get_message_id to get the ID of InputMessageID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.