Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Update Update #34

Merged
merged 8 commits into from
Mar 2, 2023
Merged

The Update Update #34

merged 8 commits into from
Mar 2, 2023

Conversation

Tech-TTGames
Copy link
Owner

A general batch of QOL updates.

  • The /join command [Tool] Join thread #23
  • Separated staff roles into perms ("staff") and pings ("observers")
  • Shared Config object across cogs. (Less reloads needed)
  • Probably less reload-needy owner check
  • The Parameters described

@Tech-TTGames Tech-TTGames requested a review from kk5dire March 2, 2023 18:09
@Tech-TTGames Tech-TTGames added Type: Enhancement An improvement to an already existing feature. Type: Feature A new feature request. labels Mar 2, 2023
@benfoster04 benfoster04 self-requested a review March 2, 2023 18:09
kk5dire
kk5dire previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@kk5dire kk5dire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kk5dire
Copy link
Collaborator

kk5dire commented Mar 2, 2023

Autofix from @deepsourcebot on https://deepsource.io/gh/Tech-TTGames/Tickets-Plus/run/08e978f9-aa79-486f-b076-02a33dc522df/python/

@Tech-TTGames Tech-TTGames requested a review from kk5dire March 2, 2023 18:14
@Tech-TTGames Tech-TTGames enabled auto-merge March 2, 2023 18:15
@Tech-TTGames Tech-TTGames merged commit 573e6e9 into main Mar 2, 2023
@Tech-TTGames Tech-TTGames deleted the dev-minor branch March 2, 2023 18:24
@kk5dire
Copy link
Collaborator

kk5dire commented Mar 2, 2023

Longest check imaginable

@kk5dire kk5dire linked an issue Mar 2, 2023 that may be closed by this pull request
[Tool] Join thread #23
Closed
@kk5dire kk5dire mentioned this pull request Mar 2, 2023
Closed
benfoster04
benfoster04 reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@benfoster04 benfoster04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to probably look further into consistency across the board regarding changes made in extchecks.py and "A probably bad way to work around the poor design of discord.py's app_command checks." Otherwise LGTM great work as always @Tech-TTGames

@Tech-TTGames Tech-TTGames added Status: Completed It's done! The feature/fix has been deployed. Archive: Old Style This issue has been submitted before a major reform in issue style. It cannot be used as reference. labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfoster04 benfoster04 benfoster04 left review comments

@kk5dire kk5dire kk5dire approved these changes

Assignees

@Tech-TTGames Tech-TTGames

Labels
Archive: Old Style This issue has been submitted before a major reform in issue style. It cannot be used as reference. Status: Completed It's done! The feature/fix has been deployed. Type: Enhancement An improvement to an already existing feature. Type: Feature A new feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tool] Join thread
3 participants
@Tech-TTGames @kk5dire @benfoster04