Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Issue templates #41

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Update Issue templates #41

merged 5 commits into from
Mar 6, 2023

Conversation

kk5dire
Copy link
Collaborator

@kk5dire kk5dire commented Mar 6, 2023

No description provided.

@kk5dire kk5dire added the Type: Documentation Improvements or additions to documentation. label Mar 6, 2023
@kk5dire kk5dire changed the title Update enhancement.md Update Issue templates Mar 6, 2023
@kk5dire kk5dire marked this pull request as ready for review March 6, 2023 02:48
@kk5dire kk5dire enabled auto-merge March 6, 2023 02:49
benfoster04
benfoster04 requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@benfoster04 benfoster04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from changes requested, LGTM and thank you for the work :)

.github/ISSUE_TEMPLATE/enhancement.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/enhancement.md Outdated Show resolved Hide resolved
kk5dire added 2 commits March 6, 2023 02:34
@kk5dire
Update enhancement.md
e7f53ab 
Signed-off-by: akkd <[email protected]>
@kk5dire
Update enhancement.md
bf54095 
Comp2+

Signed-off-by: akkd <[email protected]>
@kk5dire kk5dire requested a review from benfoster04 March 6, 2023 07:37
Tech-TTGames
Tech-TTGames approved these changes Mar 6, 2023
View reviewed changes
Copy link
Owner

@Tech-TTGames Tech-TTGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Tech-TTGames Tech-TTGames self-requested a review March 6, 2023 07:52
Tech-TTGames
Tech-TTGames approved these changes Mar 6, 2023
View reviewed changes
Copy link
Owner

@Tech-TTGames Tech-TTGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a missclick.

benfoster04
benfoster04 approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@benfoster04 benfoster04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fabulous, thank you for the changes! LGTM, cleared for merge.

@kk5dire kk5dire merged commit 0eae11f into main Mar 6, 2023
@kk5dire kk5dire deleted the kk5dire-issuetemp-patch-1 branch March 6, 2023 09:04
@Tech-TTGames Tech-TTGames added Status: Completed It's done! The feature/fix has been deployed. Archive: Old Style This issue has been submitted before a major reform in issue style. It cannot be used as reference. labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfoster04 benfoster04 benfoster04 approved these changes

@Tech-TTGames Tech-TTGames Tech-TTGames approved these changes

Assignees
No one assigned
Labels
Archive: Old Style This issue has been submitted before a major reform in issue style. It cannot be used as reference. Status: Completed It's done! The feature/fix has been deployed. Type: Documentation Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kk5dire @benfoster04 @Tech-TTGames