Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Formatting] Remove blank spaces #44

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[Formatting] Remove blank spaces #44

merged 1 commit into from
Mar 9, 2023

Conversation

kk5dire
Copy link
Collaborator

@kk5dire kk5dire commented Mar 9, 2023

Remove blank spaces for formatting reasons

Remove blank spaces for formatting

Signed-off-by: akkd <[email protected]>
@kk5dire kk5dire added the Priority: 3 Issue does not require any attention and will be handled in free time. label Mar 9, 2023
@kk5dire kk5dire self-assigned this Mar 9, 2023
@kk5dire kk5dire requested a review from Tech-TTGames March 9, 2023 12:45
@kk5dire kk5dire enabled auto-merge March 9, 2023 12:45
@Tech-TTGames Tech-TTGames added the Type: Style A change to the style of code containing no material changes. label Mar 9, 2023
Copy link
Owner

@Tech-TTGames Tech-TTGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright but next time use the actual PR template you hear?

@kk5dire kk5dire merged commit 0ec5395 into main Mar 9, 2023
@kk5dire kk5dire deleted the kk5dire-patch-1 branch March 9, 2023 13:07
@kk5dire
Copy link
Collaborator Author

kk5dire commented Mar 9, 2023

Alright but next time use the actual PR template you hear?

There would be no applicable or reasonable use to apply the PR template on a change like mine.

How would my formatting correction be used in the future?
How would it detract from what this currently is?
Etc. Etc.

The PR template makes some sense for a larger addition that is making more changes, but for smaller changes, it is almost completly invalidated.

@Tech-TTGames
Copy link
Owner

Alright but next time use the actual PR template you hear?

There would be no applicable or reasonable use to apply the PR template on a change like mine.

How would my formatting correction be used in the future? How would it detract from what this currently is? Etc. Etc.

The PR template makes some sense for a larger addition that is making more changes, but for smaller changes, it is almost completly invalidated.

I don't mean you keep the whole template. Just the general format and remove anything that doesn't work. It's just more uniform that way.

@kk5dire
Copy link
Collaborator Author

kk5dire commented Mar 9, 2023

Alright but next time use the actual PR template you hear?

There would be no applicable or reasonable use to apply the PR template on a change like mine.
How would my formatting correction be used in the future? How would it detract from what this currently is? Etc. Etc.
The PR template makes some sense for a larger addition that is making more changes, but for smaller changes, it is almost completly invalidated.

I don't mean you keep the whole template. Just the general format and remove anything that doesn't work. It's just more uniform that way.

The only thing I would have kept in that case would have been the changes made-

Which I still feel would be a bit exessive to have

Changes made

  • Removed a space

or something along those lines.

Perhaps I could have done something along the line of

Changes made

  • Removed a space
    • Improved formatting

To make it less empty.

@Tech-TTGames
Copy link
Owner

Alright but next time use the actual PR template you hear?

There would be no applicable or reasonable use to apply the PR template on a change like mine.
How would my formatting correction be used in the future? How would it detract from what this currently is? Etc. Etc.
The PR template makes some sense for a larger addition that is making more changes, but for smaller changes, it is almost completly invalidated.

I don't mean you keep the whole template. Just the general format and remove anything that doesn't work. It's just more uniform that way.

The only thing I would have kept in that case would have been the changes made-

Which I still feel would be a bit exessive to have

Changes made

  • Removed a space

or something along those lines.

Perhaps I could have done something along the line of

Changes made

  • Removed a space

    • Improved formatting

To make it less empty.

Yeah, I don't actually have any issues with it, just for next time.

@kk5dire
Copy link
Collaborator Author

kk5dire commented Mar 9, 2023

Yeah, I don't actually have any issues with it, just for next time.
The problem with having a template is that sometimes there is a situation where the template dosent really apply, and a compromise for the template needs to be made.

Ex, For when there isnt that many things changed, there is less of a need for bulleting or listing items.
But then again, I will see (looking into it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 3 Issue does not require any attention and will be handled in free time. Type: Style A change to the style of code containing no material changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants