Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus version upgrade and Type Pollution mitigation #7861

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Quarkus version upgrade and Type Pollution mitigation #7861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
687caf9
Upgrade to Quarkus 2.15.0
franz1981 Jan 16, 2023
9996d58
Mitigate Type Profiling issues due to VERIFYING QUERY chunked responses
franz1981 Jan 16, 2023
3999776
Shrink Netty's pipeline by removing IdleStateHandler
franz1981 Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frameworks/Java/quarkus/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<packaging>pom</packaging>

<properties>
<quarkus.version>2.14.0.Final</quarkus.version>
<quarkus.version>2.15.0.Final</quarkus.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
Expand Down
2 changes: 2 additions & 0 deletions ...va/quarkus/resteasy-reactive-hibernate-reactive/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,5 @@ quarkus.log.level=INFO

quarkus.vertx.prefer-native-transport=true

# Resteasy-reactive config to always send Content-Length on HTTP res and avoid chunked res
quarkus.resteasy-reactive.output-buffer-size=20480
2 changes: 2 additions & 0 deletions ...eworks/Java/quarkus/resteasy-reactive-hibernate/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,7 @@ quarkus.hibernate-orm.second-level-caching-enabled=false
quarkus.hibernate-orm.database.generation=validate
quarkus.hibernate-orm.log.sql=false

# Resteasy-reactive config to always send Content-Length on HTTP res and avoid chunked res
quarkus.resteasy-reactive.output-buffer-size=20480


1 change: 1 addition & 0 deletions frameworks/Java/quarkus/run_quarkus.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ JAVA_OPTIONS="-server \
-Dio.netty.buffer.checkBounds=false \
-Dio.netty.buffer.checkAccessible=false \
-Djava.util.logging.manager=org.jboss.logmanager.LogManager \
-Dquarkus.http.idle-timeout=0 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember - wasn't this made the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the quarkus doc, it doesn't seem the case (and flamegraphs agree on that too)

https://github.com/quarkusio/quarkus/blob/f92772992f88718c71e5904aea3393c30beff203/extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/HttpConfiguration.java#L125

Said 30M. Probably the http read idle timeout is zero, instead, I didn't checked

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, sorry mixed it up with a different property.

-XX:-UseBiasedLocking \
-XX:+UseStringDeduplication \
-XX:+UseNUMA \
Expand Down