Johnha/feature/create unavailability testing

[TaiHaDev]

Describe your changes

Setting up a testing environment for the project using pytest. Creating testing folders for functional and unit testing. Needed to be further refined to have development, testing, and production configuration. Currently, testing will create and get directly from the database which is not a good practice. Creating some test cases for creating unavailability endpoint with testing criteria:

• two consecutive create operations must output two consecutive event_id
• Cannot create two unavailability with the same time interval
• Cannot create availability for nonexistent user_id
• Cannot create unavailability with an end time earlier than the start time
• Cannot create unavailability with weird periodicity (to be discussed)
• There cannot be two unavailability from the same user with overlapped time interval
• Merge interval (if implemented on API)

Some significant changes:

• Creating a tests folder that will contain all future functional and unit tests for the project
• Refactoring application.py class to make use of factory method design pattern so that many instances of the application can be created, for now, it can be used in testing

Issue ticket number and link

https://fireapp-emergiq-2024.atlassian.net/jira/software/projects/FE/boards/1?selectedIssue=FE-68

[emilymclean]

In the future we should be writing our repositories etc such that we can do proper unit testing, but this is a good effort considering the code you were given!

Address the minor feedback, and remove the underscores from your branch name, just use dashes "-".

[TaiHaDev]

Hi @BenMMcLean , can you have a look at my comment and my changes :-) thank youu

[emilymclean]

Please address the issues with the smoke test, and then this can be merged.

(The smoke test just runs your code in a docker container. You can pull it locally using the tag pr-174. It'll tell you what's wrong)

[TaiHaDev]

I tried to pull request pr-174 in Git but I think you meant something else cause I didn't find anything after pulling. It would be very helpful if you can show me some resources related to this cause I have no previous knowledge about this Github ci/cd. However, I still managed to fix the error :-) It happened because I refactored application.py into using factory method. I basically reverted the changes, I don't know exactly why it happened as the logic should be the same and it didn't really break anything as far as I can see.

[TaiHaDev]

Some new changes:

• adding more testing fixtures to get JWT token and append to all testing requests so that they are authorised
• only using one application instance for all test cases
  Some drawbacks that I need to discuss with you:
• I think we need a testing environment (using in-memory database instead of creating data in real database) but I think it maybe out of the project's scope
• cannot create new application instance for testing can be fine for now but maybe hard to implement the above suggestion
  Thanks for your time ☺️

[emilymclean]

There aren't any resources AFAIK, but all you have to do to run the docker image of your code is modify the docker-compose.frontend.yml file, changing
docker pull ghcr.io/techlauncherfireapp/backend:latest to docker pull ghcr.io/techlauncherfireapp/backend:pr-<your pr number>, and running the file.

[emilymclean]

Looks good to me!