Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design handoff project #69

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

@JennieDalgren JennieDalgren self-assigned this Nov 14, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!

You have worked well with breaking up in components but you are still lacking in the styling.
The site is not responsive yet, when looking at it on a mobile i get side scroll. Also, the header/hero image is very low resolution. Also the title says music releases week 5

Dont forget to reach out for help if you need it!
💪

@Sherrydev11
Copy link
Author

Hi @JennieDalgren we have now made the updates on the changes that you requested by removing the sideskroll and making it more responsive. We have also fixed the image as you requested.

I cant seem to find that it says "music release week 5" as title... from my end it says "design handoff" as title in the PR.

Collabed with:
https://github.com/Heleneabrahamsson
https://github.com/smily342

Netlify: https://designhandofftech.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants