DLSV2-560 Prevent error when navigating back after deleting a delegate #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevwhitt-hee
approved these changes
Aug 25, 2022
kevwhitt-hee
deleted the
Develop/Fixes/DLSV2-560-RemoveStaffMemberFromMyStaffList
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deleting a delegate in Supervisor application (with confirmation prompt), prevent error as user navigates back by clicking browser's Back button.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-560
Description
Check that delegate is not null before returning delete confirmation page. If delegate is null, return to My Staff list, as the delegate is already deleted or it doesn't exists.
Screenshots
Developer checks
After confirming deletion, back button redirects to My Staff list.