Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLSV2-548 Adds id to error div in view components #1369

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

kevwhitt-hee
Copy link
Contributor

JIRA link

DLSV2-548

Description

Fixes missing aria reference issues found in testing by ensuring that error message ids are populated in view components that match the aria-labelledby of the control.

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee merged commit 2beb38c into master Aug 25, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/DLSV2-548-AddIdToErrorDivs branch August 25, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant