Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLSV2-548 Further accessibility fixes following internal and external retest #1396

Merged
merged 13 commits into from
Sep 14, 2022

Conversation

kevwhitt-hee
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee commented Sep 14, 2022

JIRA link

DLSV2-548

Description

  • Adds aria-label attributes to various links (Clear, Preview Resource etc)
  • Introduces aria-required attribute to NHS design system form control view components
  • Moves dom structure of self assessment radio button questions to use fieldset

Doesn't:

  • Remove hidden inputs that are necessary for the working of the web application
  • Address the red-herring warning in Wave that hidden inputs don't have labels - they shouldn't
  • Doesn't address warnings that two consecutive links are to the same place - they aren't, there is just a mobile and non-mobile version of the same link in breadcrumbs only one of which is ever visible

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Populates aria-required attribute as true or false accordingly and appends "(optional)" to labels if not already present.
Populates aria-required attribute for select vc
Dynamically adds "(optional)" to label if not required
Dynamically adds aria-required attribute and (optional) label append when appropriate
… list VC

Deselectable was always the inverse of Required so it has been removed in favour of the more meaningful Required property.
Because we can't remove them as per CyberDuck accessibility suggestions
@kevwhitt-hee kevwhitt-hee merged commit 05d7679 into master Sep 14, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fixes/DLSV2-548-AccessibilityFixes branch September 14, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant