Develop/fixes/dlsv2 652 spurious validation error on remove unsupervised user

[martinfoster-hee]

JIRA link

https://hee-dls.atlassian.net/jira/software/projects/DLSV2/boards/1?assignee=6321797ece3e476e42ac8a00&selectedIssue=DLSV2-652

Description

On page Supervisor>My Staff if you click the 'Remove staff member' for a person that does not have any self assessments, the following page displayed a spurious error on load (see attached screenshot).

This was caused by an error occuring in the viewmodel validation because in SupervisorDelegateViewModel.cs the property ActionConfirmed is validated as must be true (via the [BooleanMustBeTrue] decorator).

However in this edge case this ActionConfirmed = false is a valid model state, because the user has not ticked the confirmation checkbox on the 'confirm remove' page.

The solution was to clear the spurious error on this field (see attached screenshot for correct loading of the 'Confirm Remove Staff Member' page.

Screenshots

See attached before and after screenshots.

---

Developer checks

I have:

• Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
• Scanned over my own MR to ensure everything is as expected and it looks right in the browser