Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLSV2-712 enrol delegate mobile responsive-design changes #1438

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

manishagarwalnhs
Copy link
Contributor

@manishagarwalnhs manishagarwalnhs commented Oct 19, 2022

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-712

Description

in mobile view screens for enrol delegate is not showing proper

Screenshots

the screenshots can be found on https://hee-dls.atlassian.net/browse/DLSV2-712


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@kevwhitt-hee kevwhitt-hee merged commit 9e74df9 into master Oct 24, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-712-enrol-view-mobile-responsive-design branch October 24, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants